netdev
[Top] [All Lists]

Re: [patch 11/18] net/pcnet32: replace schedule_timeout() with msleep_

To: janitor@xxxxxxxxxxxxxx
Subject: Re: [patch 11/18] net/pcnet32: replace schedule_timeout() with msleep_interruptible()
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Sun, 31 Oct 2004 06:05:37 -0500
Cc: netdev@xxxxxxxxxxx, nacc@xxxxxxxxxx
In-reply-to: <E1CO1vx-0002OW-FJ@sputnik>
References: <E1CO1vx-0002OW-FJ@sputnik>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
janitor@xxxxxxxxxxxxxx wrote:
diff -puN drivers/net/pcnet32.c~msleep_interruptible-drivers_net_pcnet32 drivers/net/pcnet32.c
--- linux-2.6.10-rc1/drivers/net/pcnet32.c~msleep_interruptible-drivers_net_pcnet32 2004-10-24 17:05:14.000000000 +0200
+++ linux-2.6.10-rc1-max/drivers/net/pcnet32.c 2004-10-24 17:05:14.000000000 +0200
@@ -847,7 +847,7 @@ static int pcnet32_phys_id(struct net_de
if ((!data) || (data > (u32)(MAX_SCHEDULE_TIMEOUT / HZ)))
data = (u32)(MAX_SCHEDULE_TIMEOUT / HZ);
- schedule_timeout(data * HZ);
+ msleep_interruptible(data * 1000);


clearly and obviously ssleep()


<Prev in Thread] Current Thread [Next in Thread>