Re: [patch 12/18] net/sb1000: replace nicedelay() with msleep

netdev

Re: [patch 12/18] net/sb1000: replace nicedelay() with msleep_interrup

To:	janitor@xxxxxxxxxxxxxx
Subject:	Re: [patch 12/18] net/sb1000: replace nicedelay() with msleep_interruptible()
From:	Jeff Garzik <jgarzik@xxxxxxxxx>
Date:	Sun, 31 Oct 2004 06:05:15 -0500
Cc:	netdev@xxxxxxxxxxx, nacc@xxxxxxxxxx
In-reply-to:	<E1CO1w1-0002Uj-Hm@sputnik>
References:	<E1CO1w1-0002Uj-Hm@sputnik>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922

janitor@xxxxxxxxxxxxxx wrote:

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of nicedelay()
to guarantee the task delays as expected. Remove the prototype and
definition of nicedelay(). This is a very weird function, because it is
called to sleep in terms of usecs, but always sleeps for 1 second,
completely ignoring the parameter. I have gone ahead and followed suit,
just sleeping for a second in all cases, but maybe someone with the
hardware could tell me if perhaps the paramter *should* matter.
Also remove a random "^L" character.


use ssleep() here too

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch 12/18] net/sb1000: replace nicedelay() with msleep_interruptible(), janitor Re: [patch 12/18] net/sb1000: replace nicedelay() with msleep_interruptible(), Jeff Garzik <=

Previous by Date:	Re: [patch 13/18] net/cycx_drv: replace delay_cycx() with msleep_interruptible(), Jeff Garzik
Next by Date:	Re: [patch 11/18] net/pcnet32: replace schedule_timeout() with msleep_interruptible(), Jeff Garzik
Previous by Thread:	[patch 12/18] net/sb1000: replace nicedelay() with msleep_interruptible(), janitor
Next by Thread:	[patch 13/18] net/cycx_drv: replace delay_cycx() with msleep_interruptible(), janitor
Indexes:	[Date] [Thread] [Top] [All Lists]