Re: [patch 16/18] net/airo: replace schedule_timeout() with msleep()/msleep_interuptible()

[Jeff Garzik <jgarzik@xxxxxxxxx>]

janitor@xxxxxxxxxxxxxx wrote:
> Any comments would be appreciated.
>
> Description: Use msleep()/msleep_interruptible() [as appropriate]
> instead of schedule_timeout() to guarantee the task delays as
> expected. Also uses set_current_state() instead of direct assignment of
> current->state in one place.
>
> Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
> Signed-off-by: Maximilian Attems <janitor@xxxxxxxxxxxxxx>
>
> ---
>
>  linux-2.6.10-rc1-max/drivers/net/wireless/airo.c |   27 ++++++++---------------
>  1 files changed, 10 insertions(+), 17 deletions(-)
>
> diff -puN 
> drivers/net/wireless/airo.c~msleep+msleep_interruptible-drivers_net_wireless_airo
>  drivers/net/wireless/airo.c
> --- 
> linux-2.6.10-rc1/drivers/net/wireless/airo.c~msleep+msleep_interruptible-drivers_net_wireless_airo
>   2004-10-24 17:05:35.000000000 +0200
> +++ linux-2.6.10-rc1-max/drivers/net/wireless/airo.c    2004-10-24 
> 17:05:35.000000000 +0200
> @@ -1699,9 +1699,8 @@ static int readBSSListRid(struct airo_in
>                         issuecommand(ai, &cmd, &rsp);
>                         up(&ai->sem);
>                         /* Let the command take effect */
> -                       set_current_state (TASK_INTERRUPTIBLE);
>                         ai->task = current;
> -                       schedule_timeout (3*HZ);
> +                       msleep_interruptible(3*1000);
>                         ai->task = NULL;
>                 }
>         rc = PC4500_readrid(ai, first ? RID_BSSLISTFIRST : RID_BSSLISTNEXT,

use ssleep() here


> @@ -2950,7 +2947,7 @@ static int airo_thread(void *data) {
>                                 }
>                                 break;
>                         }
> -                       current->state = TASK_RUNNING;
> +                       set_current_state(TASK_RUNNING);
>                         remove_wait_queue(&ai->thr_wait, &wait);
>                         locked = 1;
>                 }

why are you adding barriers?

        Jeff