netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH] Change masquerade code to use first IP address of interface.

from [Patrick McHardy] [Permanent Link][Original]
To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Change masquerade code to use first IP address of interface.
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Wed, 20 Oct 2004 19:42:15 +0200
Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx
In-reply-to: <E1CKBtq-0005FC-00@gondolin.me.apana.org.au>
References: <E1CKBtq-0005FC-00@gondolin.me.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5 
Herbert Xu wrote:

Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:


+ newsrc = inet_select_addr(out, 0, RT_SCOPE_UNIVERSE);
+ if (!newsrc) {
+ printk("MASQUERADE: %s ate my IP address\n", out->name);
+ return NF_DROP;



Wouldn't it be better to select the address for the gateway that we're
sending towards?



I agree. Rusty, I already have your patch queued in a
post-2.6.9 tree, I'm going to add Herbert's patch on top.

Regards
Patrick


[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH] Make netif_rx_ni preempt-safe, Lee Revell
Next by Date:  Re: [PATCH 2.6.9] Export phys_cpu_present_map, Christoph Hellwig
Previous by Thread:  Re: [PATCH] Change masquerade code to use first IP address of interface., David S. Miller
Next by Thread:  [PATCH] tg3: reading eeprom via ethtool: not __init, Randy.Dunlap
Indexes:  [Date] [Thread] [Top] [All Lists]