Re: [PATCH 2.6.9-rc2 8/8] S2io: two buffer mode

[Jeff Garzik <jgarzik@xxxxxxxxx>]

no objections but two comments:

1) can this not be done with SKB fragments?

2) the following code needlessly uses GFP_ATOMIC:

> +                               ba = &nic->ba[i][j][k];
> +
> +                               ba->ba_0_org = (void *) kmalloc
> +                                   (BUF0_LEN + ALIGN_SIZE, GFP_ATOMIC);

and there is another example just a bit down from that one.