netdev
[Top] [All Lists]

[PATCH] pcnet32: use unsigned 1-bit fields

To: netdev <netdev@xxxxxxxxxxx>, jgarzik <jgarzik@xxxxxxxxx>, tsbogend@xxxxxxxxxxxxxxxx, brazilnut@xxxxxxxxxx
Subject: [PATCH] pcnet32: use unsigned 1-bit fields
From: "Randy.Dunlap" <rddunlap@xxxxxxxx>
Date: Sun, 10 Oct 2004 15:44:46 -0700
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 0.8 (X11/20040913)

1-bit fields should be unsigned. Keeps sparse happy, keeps gcc straight.

~Randy

Fix sparse warning and tell gcc that 1-bit fields are unsigned.
drivers/net/pcnet32.c:362:21: warning: dubious one-bit signed bitfield

Signed-off-by: Randy Dunlap <rddunlap@xxxxxxxx>

diffstat:=
 drivers/net/pcnet32.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff -Naurp ./drivers/net/pcnet32.c~pcnet_bits ./drivers/net/pcnet32.c
--- ./drivers/net/pcnet32.c~pcnet_bits  2004-08-13 22:36:33.000000000 -0700
+++ ./drivers/net/pcnet32.c     2004-10-10 15:23:07.964797120 -0700
@@ -359,9 +359,9 @@ struct pcnet32_private {
     struct net_device_stats stats;
     char               tx_full;
     int                        options;
-    int        shared_irq:1,                   /* shared irq possible */
-       dxsuflo:1,                      /* disable transmit stop on uflo */
-       mii:1;                          /* mii port available */
+    unsigned int       shared_irq:1,   /* shared irq possible */
+                       dxsuflo:1,      /* disable transmit stop on uflo */
+                       mii:1;          /* mii port available */
     struct net_device  *next;
     struct mii_if_info mii_if;
     struct timer_list  watchdog_timer;

<Prev in Thread] Current Thread [Next in Thread>