netdev
[Top] [All Lists]

Re: [PATCH] pktgen: sprintf arg type warning

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH] pktgen: sprintf arg type warning
From: Sam Leffler <sam@xxxxxxxxx>
Date: Sat, 09 Oct 2004 10:30:09 -0700
Cc: "Randy.Dunlap" <rddunlap@xxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20041008221934.42a6bc7a.davem@davemloft.net>
Organization: Errrno Consulting
References: <20041008203027.643a2a97.rddunlap@osdl.org> <20041008221934.42a6bc7a.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 0.8 (Macintosh/20040913)
David S. Miller wrote:
On Fri, 8 Oct 2004 20:30:27 -0700
"Randy.Dunlap" <rddunlap@xxxxxxxx> wrote:


Fix sprintf arg type error (gcc 3.3.3), although it looks more like
a gcc problem than a kernel source code problem to me.
Doesn't matter on x86-32.  Fixes a warning on x86-64.

net/core/pktgen.c:607: warning: long long unsigned int format, long unsigned int arg (arg 4)


This won't fix the problem on sparc64 where u64 is an "unsigned long"
So, just cast the thing to the type gcc wants "unsigned long long"


Other systems have addressed this problem by extending printf with portable %formats.


        Sam

<Prev in Thread] Current Thread [Next in Thread>