David S. Miller wrote:
On Wed, 06 Oct 2004 17:56:05 -0700
Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:
It may be that other programs would like to use the notify_queue_woken hook, so
if this were ever to hit the kernel proper, might want to make this a linked
list
of callbacks instead of a simple pointer.
This sort of suggests that pktgen may be better implemented
via a kind of special queueing discipline. Just an idea.
Care to elaborate? From what I can tell, the default code wakes
up the soft-irq thread when the NIC queue has available space again. I
suppose that that will in turn wake up the sockets waiting to write
to that NIC again. To me, it seemed more efficient, if perhaps less
flexible, to have the queue-has-space callback to directly wake the
writer thread(s).
I do wonder how this would work with virtual interfaces, such as 802.1Q
vlans, which have no queues. I could make the pktgen hook aware of the
VLAN <-> ethX relationship, or could have the callback generate callbacks for
all associated VLANs, but neither seems very elegant or scalable.
How does the existing (non pktgen) architecture work for VLAN devices
and stopping/starting the queues in the underlying devices?
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
|