netdev
[Top] [All Lists]

[PATCH 2.6 2/7]: Remove useless variable in tc_ctl_tfilter

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: [PATCH 2.6 2/7]: Remove useless variable in tc_ctl_tfilter
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Sun, 03 Oct 2004 23:12:53 +0200
Cc: netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5
Remove useless variable that confused me.


# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/10/03 20:29:51+02:00 kaber@xxxxxxxxxxxx 
#   [NET_SCHED]: Remove useless variable in tc_ctl_tfilter
#   
#   Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
# 
# net/sched/cls_api.c
#   2004/10/03 20:29:23+02:00 kaber@xxxxxxxxxxxx +4 -4
#   [NET_SCHED]: Remove useless variable in tc_ctl_tfilter
#   
#   Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
# 
diff -Nru a/net/sched/cls_api.c b/net/sched/cls_api.c
--- a/net/sched/cls_api.c       2004-10-03 22:18:34 +02:00
+++ b/net/sched/cls_api.c       2004-10-03 22:18:34 +02:00
@@ -139,7 +139,7 @@
        struct tcf_proto_ops *tp_ops;
        struct Qdisc_class_ops *cops;
        unsigned long cl = 0;
-       unsigned long fh, fh_s;
+       unsigned long fh;
        int err;
 
        if (prio == 0) {
@@ -249,7 +249,7 @@
        } else if (tca[TCA_KIND-1] && rtattr_strcmp(tca[TCA_KIND-1], 
tp->ops->kind))
                goto errout;
 
-       fh_s = fh = tp->ops->get(tp, t->tcm_handle);
+       fh = tp->ops->get(tp, t->tcm_handle);
 
        if (fh == 0) {
                if (n->nlmsg_type == RTM_DELTFILTER && t->tcm_handle == 0) {
@@ -257,7 +257,7 @@
                        *back = tp->next;
                        qdisc_unlock_tree(dev);
 
-                       tfilter_notify(skb, n, tp, fh_s, RTM_DELTFILTER);
+                       tfilter_notify(skb, n, tp, fh, RTM_DELTFILTER);
                        tcf_destroy(tp);
                        err = 0;
                        goto errout;
@@ -276,7 +276,7 @@
                case RTM_DELTFILTER:
                        err = tp->ops->delete(tp, fh);
                        if (err == 0)
-                               tfilter_notify(skb, n, tp, fh_s, 
RTM_DELTFILTER);
+                               tfilter_notify(skb, n, tp, fh, RTM_DELTFILTER);
                        goto errout;
                case RTM_GETTFILTER:
                        err = tfilter_notify(skb, n, tp, fh, RTM_NEWTFILTER);
<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 2.6 2/7]: Remove useless variable in tc_ctl_tfilter, Patrick McHardy <=