netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH] introduce eth_hdr(skb)

from [Arnaldo Carvalho de Melo] [Permanent Link][Original]
To: Joe Perches <joe@xxxxxxxxxxx>
Subject: Re: [PATCH] introduce eth_hdr(skb)
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Date: Sat, 02 Oct 2004 14:22:41 -0300
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.10.10410021058520.7525-100000@netwinder.perches.com>
Organization: Conectiva S.A.
References: <Pine.LNX.4.10.10410021058520.7525-100000@netwinder.perches.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 0.8 (X11/20040913)


Joe Perches wrote: 

-       } else if (skb->mac.ethernet->h_proto == 
__constant_htons(ETH_P_ARP)) {
+       } else if (eth_hdr(skb)->h_proto == htons(ETH_P_ARP)) {

I believe the __constant_htons conversions to htons are incorrect.

No they aren't, look at the generated code for both variations when receiving a constant :-)

- Arnaldo


[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH] introduce eth_hdr(skb), Joe Perches
Next by Date:  Re: [PATCH] introduce eth_hdr(skb), Joe Perches
Previous by Thread:  Re: [PATCH] introduce eth_hdr(skb), Joe Perches
Next by Thread:  Re: [PATCH] introduce eth_hdr(skb), Joe Perches
Indexes:  [Date] [Thread] [Top] [All Lists]