netdev
[Top] [All Lists]

Re: [PATCH] Improve behaviour of Netlink Sockets

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Improve behaviour of Netlink Sockets
From: Pablo Neira <pablo@xxxxxxxxxxx>
Date: Mon, 20 Sep 2004 00:14:46 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20040919212033.GA9254@gondor.apana.org.au>
References: <E1C8way-0000aH-00@gondolin.me.apana.org.au> <414DF05E.7020601@eurodev.net> <20040919212033.GA9254@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.6) Gecko/20040528 Debian/1.6-7
Hi Herbert,

Herbert Xu wrote:

However, let's do it properly rather than adding random wake_up calls.



When the buffer is full, I wake up the user process and put the kernel thread to sleep to let the user process empty the queue.


You're waking up a process based on its pid. With thread groups this is simply broken.



I didn't know about netlink applications using thread groups, in that case, submit a patch to delete that wake up call.


regards,
Pablo

<Prev in Thread] Current Thread [Next in Thread>