netdev
[Top] [All Lists]

Re: [PATCH] Fix locking bug in lltx path

To: Andi Kleen <ak@xxxxxx>
Subject: Re: [PATCH] Fix locking bug in lltx path
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Mon, 13 Sep 2004 15:39:53 -0400
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx, arjanv@xxxxxxxxxx
In-reply-to: <m3vfei9gzv.fsf@averell.firstfloor.org>
References: <m3vfei9gzv.fsf@averell.firstfloor.org>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803
Andi Kleen wrote:
Thanks to Arjan's spinlock debug kernel for finding it.

This fixes a silly missing spin lock in the relock path. For some reason it seems to still work when you don't have spinlock debugging
enabled.


Please apply.

-Andi

--------------------------------------------------------------------

Fix missing spin lock in lltx path.

Thanks to Arjan's spinlock debug kernel for finding it.

Signed-off-by: Andi Kleen <ak@xxxxxx>

diff -u linux-2.6.9rc1-bk19/net/sched/sch_generic.c-X linux-2.6.9rc1-bk19/net/sched/sch_generic.c
--- linux-2.6.9rc1-bk19/net/sched/sch_generic.c-X 2004-09-13 08:51:46.000000000 +0200
+++ linux-2.6.9rc1-bk19/net/sched/sch_generic.c 2004-09-13 19:22:50.000000000 +0200
@@ -153,8 +153,10 @@
spin_lock(&dev->queue_lock);
return -1;
}
- if (ret == -1 && nolock)
+ if (ret == -1 && nolock) {
+ spin_lock(&dev->queue_lock);
goto collision; + }

please use the fancy new constants :)

        Jeff




<Prev in Thread] Current Thread [Next in Thread>