netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 2.6] cache align qdisc data

from [Patrick McHardy] [Permanent Link][Original]
To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH 2.6] cache align qdisc data
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Tue, 03 Aug 2004 21:17:49 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20040803083820.711c917c@dell_ss3.pdx.osdl.net>
References: <410FAE42.2050909@trash.net> <20040803083820.711c917c@dell_ss3.pdx.osdl.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5 
Stephen Hemminger wrote:

This patch has qdisc code use the same interface as the netdevice code
to cache align the object private data.


These two hunks look bogus.

diff -Nru a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
--- a/net/sched/sch_hfsc.c      2004-07-27 11:03:02 -07:00
+++ b/net/sched/sch_hfsc.c      2004-07-27 11:03:02 -07:00
@@ -1554,7 +1554,6 @@
        qopt = RTA_DATA(opt);

        memset(q, 0, sizeof(struct hfsc_sched));
-       sch->stats_lock = &sch->dev->queue_lock;

        q->defcls = qopt->defcls;
        for (i = 0; i < HFSC_HSIZE; i++)

@@ -1674,7 +1673,7 @@
        RTA_PUT(skb, TCA_OPTIONS, sizeof(qopt), &qopt);

        sch->stats.qlen = sch->q.qlen;
-       if (qdisc_copy_stats(skb, &sch->stats, sch->stats_lock) < 0)
+       if (qdisc_copy_stats(skb, &sch->stats, &sch->dev->queue_lock) < 0)
                goto rtattr_failure;

return skb->len;




[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH 2.6] (1/3) add ethtool ioctl forwarding to vlan, Ben Greear
Next by Date:  Re: [PATCH 2.6 3/5]: Use double-linked list for dev->qdisc_list, Patrick McHardy
Previous by Thread:  [PATCH 2.6] cache align qdisc data, Stephen Hemminger
Next by Thread:  Re: [PATCH 2.6] cache align qdisc data, Stephen Hemminger
Indexes:  [Date] [Thread] [Top] [All Lists]