netdev
[Top] [All Lists]

Re: [PATCH] kill rtnl_exlock stubs

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] kill rtnl_exlock stubs
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Tue, 27 Jul 2004 20:38:42 +0200
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx, Jamal Hadi Salim <hadi@xxxxxxxx>
In-reply-to: <20040727095057.78c7419c@dell_ss3.pdx.osdl.net>
References: <20040727095057.78c7419c@dell_ss3.pdx.osdl.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.1) Gecko/20040722 Debian/1.7.1-3
Stephen Hemminger wrote:
Rtnetlink has some macro's that are relics from earlier locking.
They are only used a couple of places so are easy to kill.

The variable "exclusive" in rtnetlink_rcv_msg becomes useless with this patch. This patch (on top of Stephen's patch) removes it.

Regards
Patrick
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/07/27 20:32:23+02:00 kaber@xxxxxxxxx 
#   [NET]: Remove useless variable in rtnetlink_rcv_msg
#   
#   Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
# 
# net/core/rtnetlink.c
#   2004/07/27 20:32:10+02:00 kaber@xxxxxxxxx +0 -4
#   [NET]: Remove useless variable in rtnetlink_rcv_msg
# 
diff -Nru a/net/core/rtnetlink.c b/net/core/rtnetlink.c
--- a/net/core/rtnetlink.c      2004-07-27 20:33:47 +02:00
+++ b/net/core/rtnetlink.c      2004-07-27 20:33:47 +02:00
@@ -335,7 +335,6 @@
        struct rtnetlink_link *link_tab;
        struct rtattr   *rta[RTATTR_MAX];
 
-       int exclusive = 0;
        int sz_idx, kind;
        int min_len;
        int family;
@@ -401,9 +400,6 @@
                skb_pull(skb, rlen);
                return -1;
        }
-
-       if (kind != 2) 
-               exclusive = 1;
 
        memset(&rta, 0, sizeof(rta));
 
<Prev in Thread] Current Thread [Next in Thread>