netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 2.6]: Make packet scheduler clock source configurable

from [Patrick McHardy] [Permanent Link][Original]
To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH 2.6]: Make packet scheduler clock source configurable
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Fri, 23 Jul 2004 03:00:52 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxx>, shemminger@xxxxxxxx, netdev@xxxxxxxxxxx, devik@xxxxxx
In-reply-to: <41006150.9000702@trash.net>
References: <40F34740.5040100@trash.net> <1107.63.170.215.71.1089689716.squirrel@www.osdl.org> <20040712205037.573411c0.davem@redhat.com> <40F4862D.3070802@trash.net> <40F4AC8B.40706@trash.net> <20040721143110.4ab944bf.davem@redhat.com> <41004F76.1080807@trash.net> <20040722171752.341d2476.davem@redhat.com> <41006150.9000702@trash.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5
Patrick McHardy wrote:
David S. Miller wrote: 
We could bug check this in psched calibration, in fact I think
we should.



Done by this patch. I used BUG_ON instead of just printing a warning
because using packet schedulers after this error will cause a division
by zero.


Please drop this patch, psched_calibrate_clock already checks if
rdelay > delay a couple of lines above.

Regards
Patrick


[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH 2.6]: Make packet scheduler clock source configurable, Patrick McHardy
Next by Date:  Re: [PATCH 2.6]: Make packet scheduler clock source configurable, David S. Miller
Previous by Thread:  Re: [PATCH 2.6]: Make packet scheduler clock source configurable, Patrick McHardy
Next by Thread:  Re: [PATCH 2.6]: Make packet scheduler clock source configurable, David S. Miller
Indexes:  [Date] [Thread] [Top] [All Lists]