netdev
[Top] [All Lists]

Re: [PATCH] Drop ISA dependencies from IRDA drivers

To: Andi Kleen <ak@xxxxxx>
Subject: Re: [PATCH] Drop ISA dependencies from IRDA drivers
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Thu, 15 Jul 2004 17:00:38 -0400
Cc: netdev@xxxxxxxxxxx, irda-users@xxxxxxxxxxxxxxxxxxxxx, jt@xxxxxxxxxx, the_nihilant@xxxxxxxxxxxxx, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20040715205001.GA2527@muc.de>
References: <m34qo96x8m.fsf@averell.firstfloor.org> <40F6B547.7050800@pobox.com> <20040715205001.GA2527@muc.de>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510
Andi Kleen wrote:
On Thu, Jul 15, 2004 at 12:48:07PM -0400, Jeff Garzik wrote:
And with legacy ISA devices still around, I don't see a whole lot of value in differentiating between "I have ISA slots" and "I have ISA devices".


There is great value. Basically most ISA drivers are not 64bit clean (if they even still work on i386 which is also often doubtful
in 2.6) and it is a great way for 64bit archs to get rid of a lot of not working code.

I file that under "hiding bugs", since it will not be immediately obvious to a bug hunter or maintainer what the real problem is.


If a driver is broken on 64-bit, please add "&& !64BIT" to the Kconfig.

As you yourself just explained, your wish is to use CONFIG_ISA, but your intent is only coincedentally related to ISA.

        Jeff



<Prev in Thread] Current Thread [Next in Thread>