netdev
[Top] [All Lists]

Re: [PATCH] get rid of __OPTIMIZE__ requirement in net drivers

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] get rid of __OPTIMIZE__ requirement in net drivers
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Tue, 22 Jun 2004 15:52:34 -0400
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040622113052.1ef2cb7b@dell_ss3.pdx.osdl.net>
References: <20040622113052.1ef2cb7b@dell_ss3.pdx.osdl.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510
Stephen Hemminger wrote:
Several network drivers have checks that they are only built with -O.
This breaks checking with sparse and other tools, and seems like a holdover from
when drivers were built out of tree and the kernel build system was less stable.
This patch gets rid of these.


Guess is 50% correct... holdover from people compiling the drivers out-of-tree using a single shell command (that runs gcc), found at the bottom of the driver.

No objection to the patch, though, just saying :)  I'll apply...

        Jeff



<Prev in Thread] Current Thread [Next in Thread>