Re: [PATCH] natsemi update 4/4 External Fibre phy

[Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>]

Gary N Spiess wrote:

> +/* add a couple of MII definitions specific to a PORT_FIBRE 
> implementation */
> +#define MII_MCTRL      0x15    /* mode control register */
> +#define MII_IN_FX_MODE 0x0001  /* full duplex */
> +#define MII_DIS_SCRM   0x0004  /* disable scrambler */
>  

Specific to a PORT_FIBRE implementation or specific to the PHY you are 
using? I think register 0x15 is implementation specific.

Why do you actually want to handle the fibre phy as a new port? I'd 
handle phy specific code by reading the MII_PHYSID{1,2} register and 
then adding a special case if your phy is detected. The port can remain 
at PORT_MII.

--
   Manfred