netdev
[Top] [All Lists]

Re: Kernel BUG: Qos seg. fault

To: Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx>
Subject: Re: Kernel BUG: Qos seg. fault
From: Jaume Catarineu <jaume.catarineu@xxxxxxx>
Date: Tue, 25 May 2004 02:06:25 +0000
Cc: hadi@xxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx, Francois Romieu <romieu@xxxxxxxxxxxxx>
In-reply-to: <1085436571.1041.69.camel@jzny.localdomain>
References: <20040524215346.73109.qmail@web80501.mail.yahoo.com> <1085436571.1041.69.camel@jzny.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040514
Hi all,

After reading all your messages I share the Dmitry's point of view. It seems quite clear that implementing filters for TBF does not make sense. However, if it is the case, it could be nice a warning message that informs the user about the weird command introduced.

Another option (a little more complicated) would be to "decay" automatically the filter to the TBF's child qdisc. That ougth to be announced to the user also and maybe it won't be allways possible (with the default noop_qdisc is useless, isn't it?).

I will take a tour into the source code :)

Actually, the original sequence must be rewrited to:
tc qdisc add dev lo root handle 1: tbf rate 250kbit burst 5k limit 5k
tc qdisc add dev lo parent 1: handle 20: prio
tc qdisc add dev lo parent 20:1 handle 210: sfq perturb 10
tc qdisc add dev lo parent 20:2 handle 220: tbf rate 250kbit limit 5k


 tc qdisc add dev lo parent 20:3 handle 230: sfq perturb 10

 tc filter add dev lo protocol ip parent 20: prio 1 handle 2 \
                                             fw flowid 20:3

The key is the "parent 20:" (not the original "parent 1:") in the filter line.

I must say that I got astonished viewing how quick you solved the quiz. Now I don't simply believe in free software, now I really TRUST in it.

Jaume,


<Prev in Thread] Current Thread [Next in Thread>