Marc Herbert wrote:
Oups, forget the first patch, it did not tcp_enter_cwr() when
NET_XMIT_CN.
See hopefully correct patch below. Sorry for the noise.
I'm not sure I agree with this patch. Ideally, every layer should count
what it sent out, and what it drops. If a lower layer drops the segment/
packet for any reason, that is the responsibility of the lower layer to
count. This includes the qdisc layer (a topic I will come back to).
If a queing discipline were counting all incoming packets, regardless
of whether they later dropped them or not, then there would be an
inconsistency between how many TCP sent out and how many
the layer below received.
Currently, the default queing discipline statistics (dropped) are not
displayed anywhere. I have a patch that displays them in /proc/net/
along with the dev stats, which at best is a hack.
They are available if you have tc and qd support compiled, but not
via a generic statistics gathering utility like netstat -s, a fact which
a lot of people complain about. From previous suggestions and
conversations it was proposed that netstat -s be at least enhanced
to show qdisc drops (using netlink sockets, not /proc, although it
would be manyfold convenience to have them in /proc in some
suitable place).
I'd appreciate any thoughts/feedback on the issue :). What's the
best way to go about doing this?
thanks,
Nivedita
|