netdev
[Top] [All Lists]

Re: [PATCH] remove comx drivers from tree

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] remove comx drivers from tree
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Fri, 14 May 2004 13:32:02 -0400
Cc: netdev@xxxxxxxxxxx, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, Krzysztof Halasa <khc@xxxxxxxxx>, Pete Popov <ppopov@xxxxxxxxxx>
In-reply-to: <20040507111725.GA11575@lst.de>
References: <20040507111725.GA11575@lst.de>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Christoph Hellwig wrote:
the drivers have been broken since pre-2.4.0, like referencing a symbol
that was made procfs-internal in 2.3.x, haven't received maintainer
updates for about the same period and MOD_{INC,DEC}_USE_COUNT usage that
pretty much unfixable (inside warts of _horrible_ procfs abuse).

I'd say just kill them.

I have applied this to my netdev-2.6 tree, and so it should show up in -mm sometime.


drivers/net/wan/Kconfig | 113 -
drivers/net/wan/Makefile | 8
drivers/net/wan/comx-hw-comx.c | 1449 -------------------
drivers/net/wan/comx-hw-locomx.c | 495 ------
drivers/net/wan/comx-hw-mixcom.c | 959 ------------
drivers/net/wan/comx-hw-munich.c | 2853 --------------------------------------
drivers/net/wan/comx-proto-fr.c | 1013 -------------
drivers/net/wan/comx-proto-lapb.c | 550 -------
drivers/net/wan/comx-proto-ppp.c | 268 ---
drivers/net/wan/comx.c | 1127 ---------------
drivers/net/wan/comx.h | 231 ---
drivers/net/wan/comxhw.h | 112 -
12 files changed, 9178 deletions(-)


Even though it is quite moldy, I want to give people some time to object before I remove it upstream.


BTW, I plan to remove rcpci driver at the suggestion of Pete Popov, as well. It seems it's another "hasn't really worked since late 2.3.x days" driver, and nobody really has the hardware from this defunct company anymore, apparently.


        Jeff




<Prev in Thread] Current Thread [Next in Thread>