Re: [PATCH 2.6.4-rc2-bk4 2/2] pcnet32 use netif_msg_init

[Jeff Garzik <jgarzik@xxxxxxxxx>]

Don Fry wrote:
> @@ -2013,8 +2016,7 @@
>  {
>      printk(KERN_INFO "%s", version);
>  
> -    if (debug >= 0 && debug < (sizeof(int) - 1))
> -	pcnet32_debug = 1 << debug;
> +    pcnet32_debug = netif_msg_init(debug, 0);


Do you really want to default to silence?  IMO define a 
PCNET32_DEF_MSG_ENABLE with a few of the critical bits like probe-time 
information.

        Jeff