netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrout

from [Mika Penttilä] [Permanent Link][Original]
To: James Morris <jmorris@xxxxxxxxxx>
Subject: Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook
From: Mika Penttilä <mika.penttila@xxxxxxxxxxx>
Date: Mon, 16 Feb 2004 08:43:46 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxx>, Harald Welte <laforge@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, Stephen Smalley <sds@xxxxxxxxxxxxxx>
In-reply-to: <Xine.LNX.4.44.0402152048510.14031-100000@thoron.boston.redhat.com>
References: <Xine.LNX.4.44.0402152048510.14031-100000@thoron.boston.redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 


James Morris wrote:

On Sun, 15 Feb 2004, Mika Penttilä wrote:



ah, sorry, I see your point now. Maybe this copy should be in skb_checksum_help() ?



No, it's not needed by all callers, and is just a does-one-thing helper function.


- James

It is needed for cloned skbs, so check for this should go in skb_checksum_help().

--Mika




[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  PROBLEM: /proc/sys/net/ipv4/ip_dynaddr does not work correctly, Michael Schlenstedt
Next by Date:  PROBLEM: iptunnel: ioctl: Operation not supported, Arnaud
Previous by Thread:  Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook, James Morris
Next by Thread:  Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook, James Morris
Indexes:  [Date] [Thread] [Top] [All Lists]