Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook

[Mika Penttilä <mika.penttila@xxxxxxxxxxx>]

James Morris wrote:

> On Sun, 15 Feb 2004, Mika Penttilä wrote:
>
>  
>
> > skb_checksum_help() updates skb->ip_summed to CHECKSUM_NONE in the 
> > original skb, and this should be seen by the driver. With your change 
> > the checksum is calculated twice, once for the looping back packet, and 
> > once for the outgoing.
> >    
>
> [Looks like my posts are not making it to netdev]
>
> It updates ip_summed in the cloned packet header, but not in the original 
> packet, which gets sent to the driver with an already completed checksum.
>
> See the original post.
>
>
> - James

ah, sorry, I see your point now. Maybe this copy should be in 
skb_checksum_help() ?

--Mika