netdev
[Top] [All Lists]

Re: Update FarSync WAN driver in 2.4.25

To: Kevin Curtis <kevin.curtis@xxxxxxxxxxxxx>
Subject: Re: Update FarSync WAN driver in 2.4.25
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 04 Feb 2004 16:18:03 -0500
Cc: "'netdev@xxxxxxxxxxx'" <netdev@xxxxxxxxxxx>, "'davem@xxxxxxxxxx'" <davem@xxxxxxxxxx>
In-reply-to: <7C078C66B7752B438B88E11E5E20E72E25CBB5@general.hq.farsitecommunications.com>
References: <7C078C66B7752B438B88E11E5E20E72E25CBB5@general.hq.farsitecommunications.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Comments:

* please use standard indentation (one tab)

* please use constants per the include/linux/pci_ids.h standard, rather than defining your own.

* please use standard include/linux/pci.h constants, rather than defining your own (PCIILR, etc.)

* further, obtain interrupt from struct pci_dev::irq after calling pci_enable_device(); do not obtain directly via pci_read_config_xxx()

* fst_process_rx_status() could result in flooding the log

* use pci_set_master() to enable bus-mastering

* bottom halves are deprecated. do not add new code using mark_bh() and friends. Use tasklets or schedule_task().

* use pci_set_dma_mask() rather than pci_dma_supported()

* use pci_request_regions() rather than request_region()




<Prev in Thread] Current Thread [Next in Thread>