netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH] [2.4] forcedeth network driver

from [Manfred Spraul] [Permanent Link][Original]
To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: [PATCH] [2.4] forcedeth network driver
From: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
Date: Sat, 24 Jan 2004 20:02:10 +0100
Cc: Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@xxxxxxx>, marcelo.tosatti@xxxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, Jeff Garzik <jgarzik@xxxxxxxxx>
In-reply-to: <20040124195951.A1304@electric-eye.fr.zoreil.com>
References: <4012A738.2060009@gmx.net> <20040124195951.A1304@electric-eye.fr.zoreil.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624 
Francois Romieu wrote:

-> get_npriv() can still dereference a NULL pointer.


Ups, I think I fixed that. It seems the fix got lost. Sorry.

+ if (!dev->base_addr)
+ goto out_disable;
^^^^^^^^^^^
-> shouldn't it be out_relreg ?


Ok, thanks.

--
   Manfred


[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH] [2.4] forcedeth network driver, Francois Romieu
Next by Date:  RE: FW: Submission for S2io 10GbE driver, Leonid Grossman
Previous by Thread:  Re: [PATCH] [2.4] forcedeth network driver, Francois Romieu
Next by Thread:  Re: [PATCH] [2.4] forcedeth network driver, Carl-Daniel Hailfinger
Indexes:  [Date] [Thread] [Top] [All Lists]