netdev
[Top] [All Lists]

Re: [PATCH]sk98lin ethtool support

To: Mirko Lindner <demon@xxxxxxxxxxxx>
Subject: Re: [PATCH]sk98lin ethtool support
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Tue, 30 Dec 2003 19:23:41 -0500
Cc: krishnakumar@xxxxxxxxxxxxxx, mlindner@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, felix@xxxxxxxxx
In-reply-to: <3FF22333.2070004@pro-linux.de>
References: <1072779867.3632.38.camel@l5ac210.l5.laser5.co.jp> <3FF16F18.7060303@pro-linux.de> <3FF19659.8030408@pobox.com> <3FF22333.2070004@pro-linux.de>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Mirko Lindner wrote:
Jeff Garzik wrote:

Mirko Lindner wrote:

Thanks. I'll complete the support as soon I'm back in the office. All driver statistics are also available in the the proc system under /proc/net/sk98lin/




procfs statistics are deprecated...

Jeff


Jeff,

the proc statistics are integrated in the driver since kernel 2.2. I'll

Well, understood, but we don't need vendor-specific, non-standard statistics when there is a standard method to export these statistics (ETHTOOl_GSTATS).



include full support for ethtool as soon I've time to do this. At the moment I'm still working on a support for the upcoming Marvell chipset (it would be great to support Linux as soon the chip is availiable) and a Diag-Tool for all Genesis and Yukon based cards (GUI and console tool).

Make sure you don't duplicate any ethtool functions. We don't need a NIC-specific diag tool either ;-) ethtool is the preferred method moving forward, as it's already shipping in most Linux distros.


        Jeff




<Prev in Thread] Current Thread [Next in Thread>