netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [TG3] Always load TSO firmware

from [Jeff Garzik] [Permanent Link][Original]
To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [TG3] Always load TSO firmware
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Thu, 20 Nov 2003 12:41:17 -0500
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20031120092530.4dfe9016.davem@redhat.com>
References: <20031117093225.GA12420@gondor.apana.org.au> <20031117123836.2f8e70af.davem@redhat.com> <20031120095605.GA6572@gondor.apana.org.au> <20031120092530.4dfe9016.davem@redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
David S. Miller wrote: 
On Thu, 20 Nov 2003 20:56:05 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:


OK, I've cross-checked with the Broadcom drivers and the problem seems
to be specific to 5705 A1 which is the chipset in question.

The Broadcom drivers limit the number of rx descriptors to 63 while
tg3.c only limits it to 64.  It has been confirmed that lowering
the limit makes the problem go away.

Here is the patch. 


Great work.

Jeff, please push this around.  I think it's serious enough for
2.4.23-rcX personally.


Will do, though I first need to check and see if non-power-of-two has any implications in the implementation...

        Jeff




[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [TG3] Always load TSO firmware, Jeff Garzik
Next by Date:  MLDv1 bug [PATCH], David Stevens
Previous by Thread:  Re: [TG3] Always load TSO firmware, Jeff Garzik
Next by Thread:  [PATCH] IPv6: Fix erratic behavior in rt6_dump_route(), Ville Nuorvala
Indexes:  [Date] [Thread] [Top] [All Lists]