Stephen Hemminger wrote:
On Tue, 18 Nov 2003 20:46:34 +0100
Xose Vazquez Perez <xose@xxxxxxxxxx> wrote:
0x018A 0x0106 LevelOne FPC-0106TX
0x126C 0x1211 Nortel Networks 10/100BaseTX
0x1743 0x8139 Peppercon AG ROL-F
0x021B 0x8139 Compaq HNE-300
Maybe time to start using pci_ids.h?
This is mainly a matter of opinion. My opinion: no. ;-)
I think it's rather silly to keep adding to pci_ids.h, when the ids are
just arbitrary hex numbers with no useful value. I certainly support
mnemonic constants when they have value... but if the _only_ place a PCI
id constant exists is (a) in a pci_device_id list and (b) in pci_ids.h,
then it seems rather wasteful rather than helpful.
IMO, the constants just bloat the pci_device_id list, whereas the ones
with hex numbers are nice, single lines.
As an aside, include/linux/pci_ids.h is a heavily patched file, and
conflicts occur all the time.
Jeff
|