netdev
[Top] [All Lists]

Re: [PATCH]: Adjust qlen when grafting in multiple qdiscs

To: hadi@xxxxxxxxxx
Subject: Re: [PATCH]: Adjust qlen when grafting in multiple qdiscs
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Mon, 17 Nov 2003 15:40:32 +0100
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1069076786.1075.19.camel@jzny.localdomain>
References: <3FB3996A.6080008@trash.net> <1069076786.1075.19.camel@jzny.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031107 Debian/1.5-3
Hi Jamal,

I've tested tbf and prio changes before and after. Unfortunately I've never used dsmark so I didn't test this part. I did try to make sure
my changes make sense, and I still don't see why this wouldn't be
correct. dsmark increments sch->q.qlen in enqueue, so it needs to
adjust it in dsmark_graft if the old queue is non-empty. If this is
wrong, please enlighten me so I can fix my patch.


Best regards,
Patrick


jamal wrote:

Did you test some of this stuff or just did a mass-edit? I havent paid
attention to all the details, but what would decrementing sch->q.qlen on
grafting mean on a dsmark?


cheers,
jamal






<Prev in Thread] Current Thread [Next in Thread>