netdev
[Top] [All Lists]

Re: [PATCH] ibmtr -- convert to new probeing

To: Stephen Hemminger <shemminger@xxxxxxxx>, "Mike_Phillips@xxxxxxxxxxx" <Mike_Phillips@xxxxxxxxxxx>
Subject: Re: [PATCH] ibmtr -- convert to new probeing
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Fri, 14 Nov 2003 20:07:33 -0500
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20031113112440.2fe0e12c.shemminger@osdl.org>
References: <20031113112440.2fe0e12c.shemminger@osdl.org>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Stephen Hemminger wrote:
This patch applies against net-drivers-2.5-exp.  The line number offsets assume
the earlier patchset, but this change doesn't overlap all those ether changes.

        * convert ibmtr driver to using the new probe interface -- ibmtr_probe2
        * keep old ibmtr_probe for use as init handle because ibmtr_cs uses it
        * cleanup error paths in ibmtr_probe1 and module init
        * make only used locally functions static
        * do request_region before doing i/o
        * irq and mem were not really settable as module parameters so removed


Given that there has been some other activity in this driver, I would prefer to wait for Mike's ACK, before applying to net-drivers-2.5-exp (and eventually 2.6 when it re-opens).

        Jeff




<Prev in Thread] Current Thread [Next in Thread>