netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH] ethertap can use alloc_etherdev

from [Jeff Garzik] [Permanent Link][Original]
To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] ethertap can use alloc_etherdev
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Tue, 11 Nov 2003 18:52:48 -0500
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20031111144557.38bde052.shemminger@osdl.org>
References: <20031111144557.38bde052.shemminger@osdl.org>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Stephen Hemminger wrote: 
Can use alloc_etherdev, don't need to call ether_setup.
Found by viro.

diff -Nru a/drivers/net/ethertap.c b/drivers/net/ethertap.c
--- a/drivers/net/ethertap.c Tue Nov 11 09:36:15 2003
+++ b/drivers/net/ethertap.c Tue Nov 11 09:36:15 2003
@@ -72,8 +72,7 @@
struct net_device *dev;
int err = -ENOMEM;
- dev = alloc_netdev(sizeof(struct net_local), "tap%d",
- ether_setup);
+ dev = alloc_etherdev(sizeof(struct net_local));


Um? This clearly changes the device's interface name, which alloc_etherdev() not ether_setup() assigns.

        Jeff




[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: network interface cards native vlans support in linux kernel?, Rask Ingemann Lambertsen
Next by Date:  Re: IPv6/sparc64: icmp port unreachable corruption, David S. Miller
Previous by Thread:  [PATCH] ethertap can use alloc_etherdev, Stephen Hemminger
Next by Thread:  Re: [PATCH] ethertap can use alloc_etherdev, Stephen Hemminger
Indexes:  [Date] [Thread] [Top] [All Lists]