netdev
[Top] [All Lists]

Re: [RFC] [PATCH 2/3] tg3 netpoll hook

To: Keith Owens <kaos@xxxxxxxxxx>
Subject: Re: [RFC] [PATCH 2/3] tg3 netpoll hook
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Sat, 04 Oct 2003 23:21:10 -0400
Cc: Matt Mackall <mpm@xxxxxxxxxxx>, netdev@xxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxx>
In-reply-to: <31674.1065323779@ocs3.intra.ocs.com.au>
References: <31674.1065323779@ocs3.intra.ocs.com.au>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Keith Owens wrote:
On Sat, 04 Oct 2003 23:11:27 -0400, Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

Matt Mackall wrote:

Have an opinion on s/->poll_controller/->netpoll/?

I don't like either name, but don't have any better suggestions either, besides something extremely verbose like ->process_hw_events().


"poll_controller" is annoying because (a) it's way too close to NAPI, but (b) it's a reasonably accurate description of what it does.

I think "netpoll" is even worse... It describes who calls it, not what it does.


->polled_io ?


Not too bad...   Better than any suggestion of mine, at any rate :)

        Jeff




<Prev in Thread] Current Thread [Next in Thread>