netdev
[Top] [All Lists]

Re: [RFC] [PATCH 2/3] tg3 netpoll hook

To: Matt Mackall <mpm@xxxxxxxxxxx>
Subject: Re: [RFC] [PATCH 2/3] tg3 netpoll hook
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Sat, 04 Oct 2003 23:11:27 -0400
Cc: netdev@xxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxx>
In-reply-to: <20031005025512.GF13573@waste.org>
References: <20031003014505.GS1897@waste.org> <3F7F857D.5010504@pobox.com> <20031005025512.GF13573@waste.org>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Matt Mackall wrote:
Have an opinion on s/->poll_controller/->netpoll/?


I have an opinion, yes :)  which I despise myself for holding...

I don't like either name, but don't have any better suggestions either, besides something extremely verbose like ->process_hw_events().

"poll_controller" is annoying because (a) it's way too close to NAPI, but (b) it's a reasonably accurate description of what it does.

I think "netpoll" is even worse... It describes who calls it, not what it does.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>