netdev
[Top] [All Lists]

Re: mod_timer improvement

To: netdev@xxxxxxxxxxx
Subject: Re: mod_timer improvement
From: Steve Modica <modica@xxxxxxx>
Date: Thu, 02 Oct 2003 12:15:14 -0500
In-reply-to: <3F7C5863.1080403@sgi.com>
Organization: SGI
References: <3F7C5863.1080403@sgi.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030425
D'OH! Sorry about the formatting.  I think this is better:


@@ -207,6 +207,14 @@ int ret; unsigned long flags;

+        /*
+        * This is a common optimization triggered by the
+        * networking code - if the timer is re-modified
+        * to be the same thing then just return:
+        */
+        if (timer->expires == expires && timer_pending(timer))
+               return 1;
+
        spin_lock_irqsave(&timerlist_lock, flags);
        timer->expires = expires;
        ret = detach_timer(timer);



--
Steve Modica
work: 651-683-3224
mobile: 651-261-3201
MTS-Technical Lead
"Give a man a fish, and he will eat for a day, hit him with a fish and
he leaves you alone" - me


<Prev in Thread] Current Thread [Next in Thread>