netdev
[Top] [All Lists]

[PATCH] Unneeded memory barrier in net/irda code

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: [PATCH] Unneeded memory barrier in net/irda code
From: Felipe W Damasio <felipewd@xxxxxxxxxxxx>
Date: Tue, 16 Sep 2003 16:53:42 -0300
Cc: irda-users@xxxxxxxxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021226 Debian/1.2.1-9
        Hi Jeff,

Patch against 2.6-test5 to remove 2 unneeded memory barriers when setting current to TASK_RUNNING.

        Please consider applying.

        Thanks,

Felipe
--- linux-2.6.0-test5/drivers/net/irda/sir_kthread.c.orig       2003-09-16 
16:49:52.000000000 -0300
+++ linux-2.6.0-test5/drivers/net/irda/sir_kthread.c    2003-09-16 
16:50:09.000000000 -0300
@@ -132,7 +132,7 @@
                if (list_empty(&irda_rq_queue.request_list))
                        schedule();
                else
-                       set_task_state(current, TASK_RUNNING);
+                       __set_task_state(current, TASK_RUNNING);
                remove_wait_queue(&irda_rq_queue.kick, &wait);
 
                /* make swsusp happy with our thread */
@@ -165,7 +165,7 @@
                if (atomic_read(&irda_rq_queue.num_pending))
                        schedule();
                else
-                       set_task_state(current, TASK_RUNNING);
+                       __set_task_state(current, TASK_RUNNING);
                remove_wait_queue(&irda_rq_queue.done, &wait);
        }
 }
<Prev in Thread] Current Thread [Next in Thread>