netdev
[Top] [All Lists]

Re: [PATCH] (3/8) ltpc - convert to new initialization

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] (3/8) ltpc - convert to new initialization
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 03 Sep 2003 20:48:42 -0400
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20030903164916.2809d4a5.shemminger@osdl.org>
Organization: none
References: <20030903164916.2809d4a5.shemminger@osdl.org>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk
Stephen Hemminger wrote:
-int __init ltpc_probe(struct net_device *dev)
+struct net_device * __init ltpc_probe(void)
[...]
/* probe for the I/O port address */
- if (io != 0x240 && request_region(0x220,8,"ltpc")) {
- x = inb_p(0x220+6);
- if ( (x!=0xff) && (x>=0xf0) ) {
- io = 0x220;
- portfound=1;
- }
- else {
- release_region(0x220,8);
- }
- }

if (io != 0x220 && request_region(0x240,8,"ltpc")) {
y = inb_p(0x240+6);
if ( (y!=0xff) && (y>=0xf0) ){ io = 0x240;
- portfound=1;
- }
- else {
- release_region(0x240,8);
+ goto got_port;
}
+ release_region(0x240,8);
} -
- if(io && !portfound && request_region(io,8,"ltpc")){
- portfound = 1;
- }
- if(!portfound) {
- /* give up in despair */
- printk(KERN_ERR "LocalTalk card not found; 220 = %02x, 240 = %02x.\n", x,y);
- return -1;
+ if (io != 0x240 && request_region(0x220,8,"ltpc")) {
+ x = inb_p(0x220+6);
+ if ( (x!=0xff) && (x>=0xf0) ) {
+ io = 0x220;
+ goto got_port;
+ }
+ release_region(0x220,8);
}


why did the order of probing change?

It used to be "0x220 -> 0x240", now it's "0x240 -> 0x220"

        Jeff




<Prev in Thread] Current Thread [Next in Thread>