netdev
[Top] [All Lists]

The recent free_netdev() conversion...

To: Maillist netdev <netdev@xxxxxxxxxxx>
Subject: The recent free_netdev() conversion...
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Mon, 01 Sep 2003 10:59:09 -0400
Organization: none
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk
Note that a lot of error paths were not caught. In the typical driver you have:

->probe()

        dev = alloc_etherdev()
        blah_probe()
        if blah_probe() fails
                goto err_out
        register_netdev()
        return 0;

    err_out:
        kfree(dev);


->remove() free_netdev(dev);



The "kfree" needs to be a free_netdev() too.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>