netdev
[Top] [All Lists]

Re: [PATCH] (0/9) free_netdev -- delay freeing of net_device structure t

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] (0/9) free_netdev -- delay freeing of net_device structure till after last use
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Tue, 19 Aug 2003 16:44:27 -0400
Cc: shemminger@xxxxxxxx, netdev@xxxxxxxxxxx, mochel@xxxxxxxx
In-reply-to: <20030819132432.4c601c5f.davem@redhat.com>
Organization: none
References: <20030819121800.009db89b.shemminger@osdl.org> <20030819124818.476dc36d.davem@redhat.com> <3F42877B.9040407@pobox.com> <20030819132432.4c601c5f.davem@redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk
David S. Miller wrote:
On Tue, 19 Aug 2003 16:24:27 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:


Also, my tendency is to apply patches 1-8, and not apply patch 9 just yet. Even though patch 9 is a fix, those specific areas of code, I'm betting, will change when those drivers are fixed WRT full dynamic allocation and refcounting.

Comments?


I disagree about patch 9.

These drivers already dynamically allocate their netdev
structs, so they do not require any more fixing.  I just
double checked each driver changes in patch 9 and to me
this is undoubtedly the case.

These are just pure bug fixes.


Ok with me, then.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>