netdev
[Top] [All Lists]

Re: [PATCH] Move eth_mac_addr and eth_change_mtu

To: Matthew Wilcox <willy@xxxxxxxxxx>
Subject: Re: [PATCH] Move eth_mac_addr and eth_change_mtu
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Fri, 11 Jul 2003 16:57:21 -0400
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20030711182530.GH20424@parcelfarce.linux.theplanet.co.uk>
Organization: none
References: <20030711181946.GG20424@parcelfarce.linux.theplanet.co.uk> <20030711182330.GC16037@gtf.org> <20030711182530.GH20424@parcelfarce.linux.theplanet.co.uk>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk
Matthew Wilcox wrote:
On Fri, Jul 11, 2003 at 02:23:30PM -0400, Jeff Garzik wrote:

On Fri, Jul 11, 2003 at 07:19:46PM +0100, Matthew Wilcox wrote:

Move eth_mac_addr() and eth_change_mtu() from drivers/net/net_init.c
to net/ethernet/eth.c

Why? It's not used outside of net_init.c AFAICS.


Preparation for the next stage of netdev_ops


Well, I don't see/understand this next-stage, so elaboration would be nice. As-is, I do not support merging this patch.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>