Re: [PATCH] iphase fix.

To:	davej@xxxxxxxxxxxxxxxxx
Subject:	Re: [PATCH] iphase fix.
From:	Jeff Garzik <jgarzik@xxxxxxxxx>
Date:	Thu, 15 May 2003 02:37:17 -0400
Cc:	Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to:	<200305150417.h4F4HTRA025809@hera.kernel.org>
Organization:	none
References:	<200305150417.h4F4HTRA025809@hera.kernel.org>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk

Linux Kernel Mailing List wrote:

ChangeSet 1.1127, 2003/05/14 20:44:02-07:00, davej@xxxxxxxxxxxxxxxxx

        [PATCH] iphase fix.
        
        This went into 2.4 nearly a year back with the wonderfully
        descriptive  "Fix from maintainer" comment.

diff -Nru a/drivers/net/fc/iph5526.c b/drivers/net/fc/iph5526.c
--- a/drivers/net/fc/iph5526.c  Wed May 14 21:17:37 2003
+++ b/drivers/net/fc/iph5526.c  Wed May 14 21:17:37 2003
@@ -2984,8 +2984,7 @@
         */
        if ((type == ETH_P_ARP) || (status == 0))
                dev_kfree_skb(skb);
-       else
-               netif_wake_queue(dev);
+       netif_wake_queue(dev);
        LEAVE("iph5526_send_packet");

This appears to revert a fix.

You only want to wake the queue if you have room to queue another skb.

        Jeff

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] iphase fix., Jeff Garzik <= Re: [PATCH] iphase fix., Jeff Garzik Re: [PATCH] iphase fix., Dave Jones

Previous by Date:	Re: link error building kernel with gcc-3.3, David S. Miller
Next by Date:	Re: [PATCH] iphase fix., Dave Jones
Previous by Thread:	Re: link error building kernel with gcc-3.3, James Morris
Next by Thread:	Re: [PATCH] iphase fix., Jeff Garzik
Indexes:	[Date] [Thread] [Top] [All Lists]