netdev
[Top] [All Lists]

Re: e100: "Freeing alive device f7dd8000, eth%d"

To: Scott Feldman <scott.feldman@xxxxxxxxx>
Subject: Re: e100: "Freeing alive device f7dd8000, eth%d"
From: Stefan Rompf <srompf@xxxxxx>
Date: Mon, 07 Apr 2003 18:49:31 +0200
Cc: Andrew Morton <akpm@xxxxxxxxx>, netdev@xxxxxxxxxxx
References: <Pine.LNX.4.44.0304052219240.5390-100000@localhost.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
Hi,

Scott Feldman wrote:

> This should do the trick, but I'd like to get some testing on it in the QA
> lab before giving thumbs up.

[...]

> +               if(!netif_carrier_ok(bdp->device) && 
> netif_running(bdp->device))

even though this will avoid the problem, I think it is the wrong
solution: Your code is still calling operating system functions on a
netdevice that has not been register_netdevice()d yet. This will invite
problems of all kind.

Cheers, Stefan

<Prev in Thread] Current Thread [Next in Thread>