netdev
[Top] [All Lists]

Re: NAPI: dev.c change to net_rx_action algorithm.

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: NAPI: dev.c change to net_rx_action algorithm.
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Fri, 08 Nov 2002 20:55:17 -0800
Cc: "'netdev@xxxxxxxxxxx'" <netdev@xxxxxxxxxxx>
Organization: Candela Technologies
References: <Pine.GSO.4.30.0211082326220.16986-100000@shell.cyberus.ca>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2a) Gecko/20020910
jamal wrote:

The only thing i can think of is that if it was legal to flog people youd be on my list. And i would hope you dont enjoy it. Why do you like to put band-aids to things? Find the real cause of why you may be having problems then cure it; putting arbitrary hacks just because you can is rather against the basic principles of engineering.

cheers,
jamal

I'm looking for the real cause. The current code does not work as I want it to. So, I'm changing things. I would love to try out any patch you might feel like contributing.

From what I can tell, the old code punishes interfaces who are
running slower at any given time.  My change, I believe, will
allow slower interfaces to gather a bit more quota so that when
they are hit with a burst of traffic, they can spend a little
extra time to clear their buffers.

I would also welcome any argument as to why my code is worse
than the existing code.  And theoretical papers be damned,
I see better results with the change below.  Why is that?

Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear



<Prev in Thread] Current Thread [Next in Thread>