netdev
[Top] [All Lists]

PATCH: Fix up VLAN memory leaks

To: "'netdev@xxxxxxxxxxx'" <netdev@xxxxxxxxxxx>, VLAN Mailing List <vlan@xxxxxxxxxxxxxxxx>
Subject: PATCH: Fix up VLAN memory leaks
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Wed, 06 Nov 2002 00:53:05 -0800
Organization: Candela Technologies
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2a) Gecko/20020910
The first patch makes VLAN code quieter w/regard to the /var/log/messages
output.

The second fixes what I believe are two memory/resource leaks.

I ran a perl script that created and destroyed thousands of VLANs...and
my box is still standing, so I think the changes are good...  Please
look them over for sanity though, I may be mis-understanding some
of Dave's changes...

Patches are against 2.4.20-rc1

Thanks,
Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear

--- /home/greear/kernel/2.4/linux-2.4.19/net/8021q/vlan_dev.c   Tue Nov  5 
21:32:42 2002
+++ vlan_dev.c  Wed Nov  6 00:18:59 2002
@@ -738,7 +738,7 @@
 
        while (dmi) {
                dev_mc_delete(dev, dmi->dmi_addr, dmi->dmi_addrlen, 0);
-               printk(KERN_INFO "%s: del %.2x:%.2x:%.2x:%.2x:%.2x:%.2x mcast 
address from vlan interface\n",
+               printk(KERN_DEBUG "%s: del %.2x:%.2x:%.2x:%.2x:%.2x:%.2x mcast 
address from vlan interface\n",
                       dev->name,
                       dmi->dmi_addr[0],
                       dmi->dmi_addr[1],
@@ -820,7 +820,7 @@
                for (dmi = vlan_dev->mc_list; dmi != NULL; dmi = dmi->next) {
                        if (vlan_should_add_mc(dmi, 
VLAN_DEV_INFO(vlan_dev)->old_mc_list)) {
                                dev_mc_add(real_dev, dmi->dmi_addr, 
dmi->dmi_addrlen, 0);
-                               printk(KERN_INFO "%s: add 
%.2x:%.2x:%.2x:%.2x:%.2x:%.2x mcast address to master interface\n",
+                               printk(KERN_DEBUG "%s: add 
%.2x:%.2x:%.2x:%.2x:%.2x:%.2x mcast address to master interface\n",
                                       vlan_dev->name,
                                       dmi->dmi_addr[0],
                                       dmi->dmi_addr[1],
@@ -838,7 +838,7 @@
                                 * delete it from the real list on the 
underlying device.
                                 */
                                dev_mc_delete(real_dev, dmi->dmi_addr, 
dmi->dmi_addrlen, 0);
-                               printk(KERN_INFO "%s: del 
%.2x:%.2x:%.2x:%.2x:%.2x:%.2x mcast address from master interface\n",
+                               printk(KERN_DEBUG "%s: del 
%.2x:%.2x:%.2x:%.2x:%.2x:%.2x mcast address from master interface\n",
                                       vlan_dev->name,
                                       dmi->dmi_addr[0],
                                       dmi->dmi_addr[1],
--- /home/greear/kernel/2.4/linux-2.4.19/net/8021q/vlan.c       Tue Nov  5 
21:32:41 2002
+++ vlan.c      Wed Nov  6 00:32:50 2002
@@ -45,7 +45,7 @@
 
 static char vlan_fullname[] = "802.1Q VLAN Support";
 static unsigned int vlan_version = 1;
-static unsigned int vlan_release = 7;
+static unsigned int vlan_release = 8;
 static char vlan_copyright[] = "Ben Greear <greearb@xxxxxxxxxxxxxxx>";
 static char vlan_buggyright[] = "David S. Miller <davem@xxxxxxxxxx>";
 
@@ -256,6 +256,10 @@
                                __grp_unhash(grp);
                                spin_unlock_bh(&vlan_group_lock);
 
+                                /* Free the group, after we have removed it 
from the hash. */
+                                kfree(grp);
+                                grp = NULL;
+                                
                                ret = 1;
                        }
 
@@ -625,7 +629,7 @@
 
                        ret = unregister_vlan_dev(dev,
                                                  
VLAN_DEV_INFO(vlandev)->vlan_id);
-
+                        dev_put(vlandev);
                        unregister_netdevice(vlandev);
 
                        /* Group was destroyed? */
<Prev in Thread] Current Thread [Next in Thread>
  • PATCH: Fix up VLAN memory leaks, Ben Greear <=