David S. Miller wrote:
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Wed, 18 Sep 2002 00:09:50 -0700
http://www.candelatech.com/sts_2.4.19.patch
I don't think I'll be applying this:
1) No tcp ipv6 bits
I know squat about this, so am reluctant to hack code there.
2) SIOC{S,G}ACCEPTLOCALADDRS added, but no 32-bit translation
code added to varions 64-bit/32-bit biarch port ioctl handling.
Also, no code added to the ioctl dispatch in the networking
so that devices could actually receive these requests.
See http://www.candelatech.com/sts2_hack.patch (32-bit only), it contains
the missing
bits, I'm not good at generating two patch sets (ie pktgen and send-to-self)
when they touch the same file...
3) Finally, it's just too damn ugly. If you have to ifdef it then
it really doesn't belong in the tree. Maybe if the device number
comparison logic changes existed via macros in tcp.h and thus
removing all the CONFIG_NET_SENDTOSELF ifdefs from tcp*.c code
it might be more palatable.
The #ifdefs were per request, I personally would like them not to be there
either. As far as I can tell, the changes are backwards compatible, so there
should be no need for ifdefs.
4) I haven't reviewed the ramifications of the route lookup changes,
that is Alexey's territory.
Sorry, these changes are pretty ugly right now.
Thanks for looking at them. I can fix the #ifdef cruft, but adding 64bit
support or hacking ipv6 is beyond my means of testing at this point, so
I cannot make those changes.
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx> <Ben_Greear AT excite.com>
President of Candela Technologies Inc http://www.candelatech.com
ScryMUD: http://scry.wanfear.com http://scry.wanfear.com/~greear
|