| To: | Marcel Holtmann <marcel@xxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [NET] make all protos partially use sk_prot |
| From: | Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> |
| Date: | Sat, 26 Mar 2005 10:42:20 -0300 |
| Cc: | Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Network Development Mailing List <netdev@xxxxxxxxxxx> |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=V9/T2KEuCF5BPt8dyXwyDujamoCjQwzxcghCa/R2ksUXtoucw5eiAduGCdV3bArJZHhr7fFwxkGlxvGrIeBz0/j5WzSqbPVbtqdPd/QyfILMuc1ATMb9KhDDLzWweWGkiYAr01Bdwbeks0M5WVif+LE1Q19LzkZ/uqn2myFDXEU= |
| In-reply-to: | <1111844163.9195.191.camel@pegasus> |
| References: | <20050326003937.GA13951@conectiva.com.br> <1111842541.9195.183.camel@pegasus> <39e6f6c705032605136bd797b2@mail.gmail.com> <39e6f6c7050326051571ef8272@mail.gmail.com> <1111844163.9195.191.camel@pegasus> |
| Reply-to: | acme@xxxxxxxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sat, 26 Mar 2005 14:36:03 +0100, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Arnaldo, > > > Ah, apart from these style changes, do you think the real changes in this > > patch > > are worth? > > actually I am the wrong person to judge on this. However if socket users > don't have to care about owner and slab anymore (or at least less), I > think it is a good thing to do. OK. > Btw all the ".slab = NULL," stuff in the proto declarations is not > needed and we normally omit values that are 0 or NULL. I used to be a top nitpicker for this kind of stuff, and avoid it a lot, but used this time only to clearly state that this protocol doesn't use a slab cache, anyway, I'll remove those as well, as we can see which protocols are not using a slab thru /proc/net/protocols, introduced in this changeset. > And some of the proto__seq_* functions are not static. What is the > reason to have them public? My mistake, thanks for pointing this out, new patch in the works. - Arnaldo |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [NET] make all protos partially use sk_prot, Marcel Holtmann |
|---|---|
| Next by Date: | [PATCH][NET] make all protos partially use sk_prot, Arnaldo Carvalho de Melo |
| Previous by Thread: | Re: [NET] make all protos partially use sk_prot, Marcel Holtmann |
| Next by Thread: | [PATCH] Remove i_sock, Matthew Wilcox |
| Indexes: | [Date] [Thread] [Top] [All Lists] |