| To: | Donald Becker <becker@xxxxxxxxx> |
|---|---|
| Subject: | Re: PATCH 2.4.0.9.2: export ethtool interface |
| From: | Andrew Morton <andrewm@xxxxxxxxxx> |
| Date: | Thu, 21 Sep 2000 22:29:39 +1100 |
| Cc: | "howling@xxxxxxxx" <havanna_moon@xxxxxxx>, netdev@xxxxxxxxxxx |
| References: | <39C883CF.9FB262FC@uow.edu.au> <Pine.LNX.4.10.10009201152510.1031-100000@vaio.greennet> |
| Sender: | owner-netdev@xxxxxxxxxxx |
Donald Becker wrote: > > ... > > Not a thing you'd want > > to poll very frequently, particularly as some drivers are racy in this > > area, and the consequences of hitting the race could be quite bad. > > spin_lock_bh() is the correct solution for mdio protection, BTW. > > Or having the timer based media monitor just skip the check until the next > tick if the lock is set. Imagine taking timer interrupt during the > user-level ioctl()... (There are a few other dangerous cases to consider as > well.) Yes. On 2.4 (at least) there is nothing to prevent the driver's ioctl() function from running on two or more CPUs simultaneously. |
| Previous by Date: | dev->hard_start_xmit return val handling correct?, Jeff Garzik |
|---|---|
| Next by Date: | Re: PATCH 2.4.0.9.2: export ethtool interface, Andi Kleen |
| Previous by Thread: | Re: PATCH 2.4.0.9.2: export ethtool interface, Donald Becker |
| Next by Thread: | Re: PATCH 2.4.0.9.2: export ethtool interface, Andi Kleen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |