Re: modular net drivers

[Andrew Morton <andrewm@xxxxxxxxxx>]

Keith Owens wrote:
> 
> Racy.  The module referred to by dev->owner might be in the middle of
> being unloaded.  You need try_inc_mod_count() with a check on its
> result instead of __MOD_INC_USE_COUNT.

eww.  That would mean the existing code is racy.  I assumed it took care
of this elsewhere. Maybe not.  try_inc_mod_count looks good.


Petr Vandrovec wrote:
> 
> 
> You should change it to
>     if (dev->owner)
>         __MOD_INC_USE_COUNT(dev->owner);
>     if (dev->open)
>         ret = dev->open(dev);
>     if (ret != 0 && dev->owner)
>         __MOD_DEC_USE_COUNT(dev->owner);
>     ...

<slaps head>