Re: Queue and SMP locking discussion (was Re: 3c59x.c)

[Andrew Morton <andrewm@xxxxxxxxxx>]

Andrew Morton wrote:
> 
> It appears to me that netif_wake_queue can be called multiple times
> within this loop,

Spit.  I missed the test_and_set_bit(__LINK_STATE_XOFF...

I still question it though:

status = inw(ioaddr + EL3_STATUS);
do {
    ...
    if (status & TxAvailable) {
        outw(AckIntr | TxAvailable, ioaddr + EL3_CMD);
        netif_wake_queue(dev);
    }
    ....
} while ((status = inw(ioaddr + EL3_STATUS)) & (IntLatch | RxComplete));

Will 'inw(ioaddr + EL3_STATUS)' continue to have the TxAvailable bit set
even after it has been acked?

-- 
-akpm-