netdev
[Top] [All Lists]

Re: Followup to netpoll issues

To: <romieu@xxxxxxxxxxxxx>
Subject: Re: Followup to netpoll issues
From: "Mark Broadbent" <markb@xxxxxxxxxxxxxx>
Date: Mon, 10 Jan 2005 22:03:14 -0000 (GMT)
Cc: <mpm@xxxxxxxxxxx>, <netdev@xxxxxxxxxxx>
Importance: Normal
In-reply-to: <20050107231815.GC17317@electric-eye.fr.zoreil.com>
References: <1105045914.7687.3.camel@tigger> <20050107002053.GD27896@electric-eye.fr.zoreil.com> <1105128887.3814.20.camel@localhost> <20050107231815.GC17317@electric-eye.fr.zoreil.com>
Reply-to: markb@xxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
Francois Romieu said:
> Mark Broadbent <markb@xxxxxxxxxxxxxx> :
> [...]
>> No need, if netpoll_cleanup is called whilst a retry is pending the tx
>> list lock is taken.  All the references to the netpoll pointer are
>> deleted from the pending list before the lock is released.
>
> I may be a bit dense but:
>
> t0             : tx_retry_wq().queue_delayed_work(tx_wq, &tx_wq_obj,
> HZ/100);
>
> t0 + 10*HZ/1000: tx_retry_wq() is done (it was not fast for sure)
>
> t0 + 20*HZ/1000: netpoll_cleanup() + module removal
>
> t0 + HZ/100    : tx_retry_wq() <- Where are its code and data ?

You logic is correct but I'm positive that netpoll.o is always built into
the kernel image and hence cannot be unloaded.
> [...]

Thanks
Mark



-- 
Mark Broadbent <markb@xxxxxxxxxxxxxx>
Web: http://www.wetlettuce.com




<Prev in Thread] Current Thread [Next in Thread>